Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document how to run in docker #21

Closed
wants to merge 1 commit into from

Conversation

MarcoIeni
Copy link
Contributor

Trying to save hours of debugging to other people 😅
After many attempts I got cargo-http-registry working in MarcoIeni/release-plz#421 🥳

Copy link
Owner

@d-e-s-o d-e-s-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks! Left one suggestion. Is there a reasoning behind the port range or is it just the first unassigned random port that popped up?

# - Server address.
# Note that 127.0.0.1 doesn't work in GitHub actions.
# Use 0.0.0.0 instead.
command: /tmp/test-registry -a 0.0.0.0:35504
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use long options in code snippets?

Suggested change
command: /tmp/test-registry -a 0.0.0.0:35504
command: /tmp/test-registry --addr 0.0.0.0:35504

@MarcoIeni
Copy link
Contributor Author

Just a random one. No reasons.
It's the one mentioned in readme +1.

@d-e-s-o
Copy link
Owner

d-e-s-o commented Aug 5, 2023

Closed via 21cd548

@d-e-s-o d-e-s-o closed this Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants